staticfanfare
/
dwm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gettextprop: check result of XGetTextProperty (undefined behaviour for XFree)

This commit is contained in:
Hiltjo Posthuma 2017-11-03 16:36:32 +01:00
parent a9b6a312a7
commit 99f78fa553
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dwm.c
View File

@ -910,8 +910,7 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size)
if (!text || size == 0) if (!text || size == 0)
return 0; return 0;
text[0] = '\0'; text[0] = '\0';
XGetTextProperty(dpy, w, &name, atom); if (!XGetTextProperty(dpy, w, &name, atom) || !name.nitems)
if (!name.nitems)
return 0; return 0;
if (name.encoding == XA_STRING) if (name.encoding == XA_STRING)
strncpy(text, (char *)name.value, size - 1); strncpy(text, (char *)name.value, size - 1);